Re: [Xen-devel] [PATCH V2] xen/arm: mm: fix nr_second calculation in setup_frametable_mappings

[Julien Grall <julien.grall@xxxxxxx>]

(CC Wei for Xen 4.7)

Hi,

On 12/05/16 14:03, Peng Fan wrote:
> On ARM64, "frametable_size >> SECOND_SHIFT" computes the number
> of second level entries, not the number of second level pages.
>
> "ROUNDUP(frametable_size, FIRST_SIZE) >> FIRST_SHIFT" which computes
> the number of the first level entries (the number of second level pages),
> is the correct one that should be used.
>
> Signed-off-by: Peng Fan <van.freenix@xxxxxxxxx>
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: Julien Grall <julien.grall@xxxxxxx>
Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

This is a bug fix for Xen 4.7 and should be backported up to Xen 4.4.

Wei, could we get a release-ack for this patch?

The computation of the number of page to allocation was wrong. This 
could result to overrun xen_first on platform with big amount of memory.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel