[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 2/9] monitor: Don't call vm_event_fill_regs from common

Hi Tamas,

On 04/05/16 15:51, Tamas K Lengyel wrote:
The prototype of vm_event_fill_regs will differ on x86 and ARM so in this patch
we move components from common to arch-specific that use this function. As
part of this patch we rename and relocate vm_event_monitor_guest_request as
monitor_guest_request from vm_event to monitor.

Would not it be possible to find a common prototype between ARM and x86?

From patch #4, the ARM prototype is:

void vm_event_fill_regs(vm_event_request_t *req,
                        const struct cpu_user_regs *regs,
                        struct domain *d)

and the x86 one is

void vm_event_fill_regs(vm_event_request_t *req);

The parameter "regs" will always be equal to guest_cpu_user_regs(). And the domain will always be current->domain.

So, IHMO, there is no need to differ between ARM and x86. This would also keep the code simple.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.