Re: [Xen-devel] [RFC 11/16] xen/arm: Detect silicon revision and set cap bits accordingly

[Julien Grall <julien.grall@xxxxxxx>]

Hi Konrad,

On 16/05/16 14:50, Konrad Rzeszutek Wilk wrote:
> On Sat, May 14, 2016 at 07:04:19PM +0100, Julien Grall wrote:
> > Hi Konrad,
> >
> > On 13/05/2016 21:37, Konrad Rzeszutek Wilk wrote:
> > > > diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c
> > > > index 7a1b56b..aa7c5b1 100644
> > > > --- a/xen/arch/arm/cpufeature.c
> > > > +++ b/xen/arch/arm/cpufeature.c
> > > > @@ -24,6 +24,22 @@
> > > >
> > > >   DECLARE_BITMAP(cpu_hwcaps, ARM_NCAPS);
> > > >
> > > > +void update_cpu_capabilities(const struct arm_cpu_capabilities *caps,
> > > > +                             const char *info)
> > > > +{
> > > > +    int i;
> > > > +
> > > > +    for ( i = 0; caps[i].matches; i++ )
> > > > +    {
> > > > +        if ( !caps[i].matches(&caps[i]) )
> > > > +            continue;
> > > > +
> > > > +        if ( !cpus_have_cap(caps[i].capability) && caps[i].desc )
> > > > +            printk("%s: %s\n", info, caps[i].desc);
> > > dprintk?
> > No, this message is useful to know the list of "features" available for the
> > platform.
> What about level? INFO?
INFO would be fine. I keep forgetting that the default is WARNING.

I will fix it in the next version.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel