Re: [Xen-devel] [PATCH RFC] Tmem cleanups for 4.7 (hopefully?).

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 5/16/16 10:58 AM, Konrad Rzeszutek Wilk wrote:
> Hey,
> 
> These four little cleanups move the bulk of tmem control ops
> from tmem.c to tmem_control.c.
> 
> Last release I moved the control tmem ops from being part of tmem
> hypercall to be part of the syscall subops - and this is the next
> step in this cleanup. (See
> http://lists.xen.org/archives/html/xen-devel/2015-10/msg03313.html)
> which will allow me to follow up on the other steps:
>  b) Fix the toolstack (cleanup)
>  c) tmem tze, dedup, and zlib code drop
> 
> Anyhow sorry for this being so tardy - xSplice had more attention :-)
> 
> Regression tests show no problems.
> 
> The patches themselves have no functionality changes thought I was itching
> to remove most of the counters. I will do that going forward, but need
> to figure out which ones make sense or if some of them can be coalesced.
> 
>  xen/common/Makefile            |   2 +-
>  xen/common/tmem.c              | 618 
> +++++------------------------------------
>  xen/common/tmem_control.c      | 443 +++++++++++++++++++++++++++++
>  xen/include/xen/tmem_control.h |  33 +++
>  xen/include/xen/tmem_xen.h     | 128 +++++++++
>  5 files changed, 672 insertions(+), 552 deletions(-)
> 
> Konrad Rzeszutek Wilk (4):
>       tmem: Move global stats in a tmem_statistics structure
>       tmem: Wrap atomic_t in struct tmem_statistics as well.
>       tmem: Move global_ individual variables in a global structure.
>       tmem: Move bulk of tmem control functions in its own file.
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
> 

So overall applying all 4 patches results in something that I think is
better. I think some improvement on the bisect-ability of the patches
and I'll toss my Reviewed-by: Doug Goldstein <cardoe@xxxxxxxxxx> on the
series.

-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel