Re: [Xen-devel] [PATCH v3 3/6] build: convert verbose to Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.05.16 at 04:16, <cardoe@xxxxxxxxxx> wrote:
> On 5/12/16 4:04 AM, Jan Beulich wrote:
>>>>> On 11.05.16 at 19:37, <cardoe@xxxxxxxxxx> wrote:
>>> On 5/11/16 4:45 AM, Jan Beulich wrote:
>>>>>>> On 10.05.16 at 23:05, <cardoe@xxxxxxxxxx> wrote:
>>>>> --- a/xen/Kconfig.debug
>>>>> +++ b/xen/Kconfig.debug
>>>>> @@ -15,4 +15,11 @@ config DEBUG
>>>>>     option is intended for development purposes only, and not for
>>>>>     production use.
>>>>>  
>>>>> +config VERBOSE_DEBUG
>>>>> + bool "Verbose debug messages"
>>>>> + default DEBUG
>>>>> + ---help---
>>>>> +   Guest output from HYPERVISOR_console_io and hypervisor parsing
>>>>> +   ELF images (dom0) is logged in the Xen ring buffer.
>>>>
>>>> The "depends on DEBUG || EXPERT" did get lost here (or, looking at
>>>> the following patch, a respective "if" framing them all).
>>>
>>> This option is always visible to someone and is not dependent on DEBUG
>>> due to the if not being possible in the form you asked. So I adjusted it
>>> to "default DEBUG" as you had asked. I can make this option dependent on
>>> DEBUG or EXPERT.
>> 
>> Same here - with the menuconfig gone, I don't see why.
> 
> So no change? From the first email I gather that it should be "depends
> on DEBUG || EXPERT" but from the last one I gather no change.

Oh, my mistake. I read the "can" in the last sentence of your
previous reply as "can only", i.e. understanding you mean either
DEBUG or EXPERT. So yes, what I meant to be asking for is
"depends on DEBUG || EXPERT" uniformly for all the DEBUG
sub-options. Which, it no longer being a menuconfig, should be
possible to express by just an "if DEBUG || EXPERT" framing them
all.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel