Re: [Xen-devel] [PATCH RFC 02/18] kbdif: add raw events passing

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.05.16 at 18:32, <andrii.anisov@xxxxxxxxxxxxxxx> wrote:
> xenkbd_raw carries raw linux event structure -- type, code & value,
> which allows support of more devices (e.g. touchscreens).

The "raw Linux event structure" may change, so you can't defer to
it. All related definitions would need to be added here, namely ...

> @@ -68,6 +70,13 @@ struct xenkbd_position
>      int32_t rel_z;       /* relative Z motion (wheel) */
>  };
>  
> +struct xenkbd_raw {
> +    uint8_t type;        /* XENKBD_TYPE_RAW */
> +    uint16_t input_type;
> +    uint16_t code;
> +    int32_t value;
> +};

... values to be contained in the three fields which don't have a
comment.

Furthermore it looks like it's the backend that would produce the
new type, and hence there would need to be a means for the
frontend to enable their producing (or else an unsuspecting
frontend might get confused). The way such negotiation works
(likely through xenbus) would need to be documented here, too.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel