[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/arm: smpboot: drop unneeded code in start_secondary

Hi Peng,

On 19/05/16 10:22, Peng Fan wrote:
CPU0 boots up secondary CPUs one by one. Before booting
one secondary CPU, CPU0 will assign hwid to smp_up_cpu
and flush cache. After the secondary CPU boots up,

NIT: s/the/a/

CPU0 will assign MPIDR_INVALID to smp_up_cpu and flush

There is no need for secondary CPUs to assign MPIDR_INVALID
to smp_up_cpu. So, drop it.

Signed-off-by: Peng Fan <van.freenix@xxxxxxxxx>
Cc: Julien Grall <julien.grall@xxxxxxx>
Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>

Reviewed-by: Julien Grall <julien.grall@xxxxxxx>


  xen/arch/arm/smpboot.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index c5109bf..6b3c157 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -309,7 +309,6 @@ void start_secondary(unsigned long boot_phys_offset,

      /* Now report this CPU is up */
-    smp_up_cpu = MPIDR_INVALID;
      cpumask_set_cpu(cpuid, &cpu_online_map);

Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.