Re: [Xen-devel] [PATCH RFC 01/18] xen/tools: Fix virtual disks helper scripts.

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, May 19, 2016 at 11:54:55PM +0300, Andrii Anisov wrote:
> Wei,
> 
> Actually it should be the oldest patch in our current series, it was
> initial researches, I tried to fit the dom0 system rootfs into
> smallest possible initramfs so lean busybox was there.
> 
> >> +#trap sigerr ERR
> > > -trap sigerr ERR
> >
> > I know why you want to comment this out but you basically break the
> > error handling protocol. See the fatal function at the beginning of this
> > file.
> And yes we should check this particular line change carefully 'cause
> it was not intelligent adjusting to busybox, just getting rid of nasty
> issue.
> 
> > And you should probably fix your own environment, too.
> I'm not sure I got the point. If we are speaking about our system we
> are tied to this
> http://processors.wiki.ti.com/index.php/Category:GLSDK in dom0. I
> doubt it will be accepted by customer switching to any rich shell.
> 

What I mean is this patch changes (breaks?) error reporting protocol so
your deployment might not function as you expect. And that's something
you need to worry about for your customer.

My bottom line is the error reporting mechanism needs to be preserved,
otherwise we risk breaking other users. Libxl currently relies on those
nodes to report error.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel