Re: [Xen-devel] [PATCH 1/2] xen/arm: add support for vm_assist hypercall

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 21/05/2016 14:27, Stefano Stabellini wrote:
> > diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
> > index 2d11b62..563f49b 100644
> > --- a/xen/include/asm-arm/config.h
> > +++ b/xen/include/asm-arm/config.h
> > @@ -199,6 +199,8 @@ extern unsigned long frametable_virt_end;
> >  #define watchdog_disable() ((void)0)
> >  #define watchdog_enable()  ((void)0)
> >
> > +#define VM_ASSIST_VALID          (0)
> This is a nit, but as VM_ASSIST_VALID is only used with #ifdef, I would
> just:
>
> #define VM_ASSIST_VALID
>
> the two previous #define are to 0, because they are replacing functions.
VM_ASSIST_VALID is used as an argument for vm_assist (see kernel.c) to 
know which option is valid. We have to define VM_ASSIST_VALID to 0 
because there no valid option for the moment on ARM.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel