[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 3/3] AMD IOMMU: Check io_handler before registering mmio handler
> -----Original Message----- > From: suravee.suthikulpanit@xxxxxxx > [mailto:suravee.suthikulpanit@xxxxxxx] > Sent: 22 May 2016 00:43 > To: xen-devel@xxxxxxxxxxxxx; Paul Durrant; jbeulich@xxxxxxxx; George > Dunlap > Cc: Keir (Xen.org); Suravee Suthikulpanit; Suravee Suthikulapanit > Subject: [PATCH v3 3/3] AMD IOMMU: Check io_handler before registering > mmio handler > > From: Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx> > > guest_iommu_init tries to register mmio handler before HVM domain > is initialized. This cause registration to silently failing. > This patch adds a sanitiy check and puts out error message. > > Signed-off-by: Suravee Suthikulapanit <suravee.suthikulpanit@xxxxxxx> This patch is now defunct isn't it? Paul > --- > xen/drivers/passthrough/amd/iommu_guest.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/xen/drivers/passthrough/amd/iommu_guest.c > b/xen/drivers/passthrough/amd/iommu_guest.c > index f96fbf4..49f00de 100644 > --- a/xen/drivers/passthrough/amd/iommu_guest.c > +++ b/xen/drivers/passthrough/amd/iommu_guest.c > @@ -890,6 +890,12 @@ int guest_iommu_init(struct domain* d) > !has_viommu(d) ) > return 0; > > + if ( d->arch.hvm_domain.io_handler == NULL ) > + { > + AMD_IOMMU_DEBUG("Error: uninitalized hvm io handler\n"); > + return 1; > + } > + > iommu = xzalloc(struct guest_iommu); > if ( !iommu ) > { > -- > 1.9.1 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |