Re: [Xen-devel] [PATCH v5 07/10] IOMMU: propagate IOMMU Device-TLB flush error up to iommu_iotlb_flush{, _all} (leaf ones).

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.05.16 at 05:42, <quan.xu@xxxxxxxxx> wrote:
> On May 18, 2016 4:08 PM, Quan Xu <quan.xu@xxxxxxxxx> wrote:
>> Propagate the IOMMU Device-TLB flush error up to the
>> iommu_iotlb_flush{,_all}.
>> 
>> This patch fixes the leaf ones.
>> --- a/xen/drivers/passthrough/vtd/iommu.c
>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>> -static void intel_iommu_iotlb_flush(struct domain *d, unsigned long gfn,
>> unsigned int page_count)
>> +static int __must_check iommu_flush_iotlb_pages(struct domain *d,
>> +                                                unsigned long gfn,
>> +                                                unsigned int
>> +page_count)
>>  {
>> -    __intel_iommu_iotlb_flush(d, gfn, 1, page_count);
>> +    return iommu_flush_iotlb(d, gfn, 1, page_count);
>>  }
>> 
>> -static void intel_iommu_iotlb_flush_all(struct domain *d)
>> +static int iommu_flush_iotlb_all(struct domain *d)
> 
> Sorry,  I should add __must_check annotation here too.

And with that adjustment
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel