[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [for-4.8 1/2] xen/arm: Convert DEBUG_DT to Kconfig

Hi Konrad,

On 24/05/16 14:38, Konrad Rzeszutek Wilk wrote:
On Tue, May 24, 2016 at 11:20:40AM +0100, Julien Grall wrote:
Convert device-tree debugging to 'Kconfig' as

The option is not enabled by default because the output is very

Signed-off-by: Julien Grall <julien.grall@xxxxxxx>

Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Cc: Jan Beulich <jbeulich@xxxxxxxx>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Cc: Tim Deegan <tim@xxxxxxx>
Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
Cc: Doug Goldstein <cardoe@xxxxxxxxxx>
  xen/Kconfig.debug           | 7 +++++++
  xen/arch/arm/domain_build.c | 4 +---
  xen/common/device_tree.c    | 4 +---
  3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
index 303bf36..59be34d 100644
--- a/xen/Kconfig.debug
+++ b/xen/Kconfig.debug
@@ -55,6 +55,13 @@ config VERBOSE_DEBUG
          Guest output from HYPERVISOR_console_io and hypervisor parsing
          ELF images (dom0) is logged in the Xen ring buffer.

+       bool "Device tree debug messages"
+       depends on HAS_DEVICE_TREE
+       ---help---
+         Device tree parsing and DOM0 device tree building messages is
+         logged in the Xen ring buffer

s/is logged/are logged/

Also missing stop at the end.

Perhaps also add:

"If unsure, say N here."

I will do all the 3 changes in the next version.

Or could this be part of the VERBOSE one (which spews out data about
ELF parsing and allows guests to do  the console_io_write hypercalls?).

The debug messages from the device tree is really verbose (it will obscure useful boot messages). So it should only be enabled when Xen does not parse correctly the device tree.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.