Re: [Xen-devel] [PATCH v3 13/16 - RFC] x86: add multiboot2 protocol support for EFI platforms

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.05.16 at 11:32, <JBeulich@xxxxxxxx> wrote:
>>>> On 15.04.16 at 14:33, <daniel.kiper@xxxxxxxxxx> wrote:
>> @@ -221,6 +372,13 @@ trampoline_setup:
>>          add     $12,%esp            /* Remove reloc() args from stack. */
>>          mov     %eax,sym_phys(multiboot_ptr)
>>  
>> +        /*
>> +         * Do not zero BSS on EFI platform here.
>> +         * It was initialized earlier.
>> +         */
>> +        cmpb    $1,sym_phys(skip_realmode)
>> +        je      1f
> 
> So what if skip_realmode is set on a legacy BIOS system because
> of the command line option or the use of TBOOT?

Oh, I see - this is still before command line parsing ran. The
commentary on this double purpose should be improved, I
think.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel