Re: [Xen-devel] [PATCH 1/4] xen/arm: Change the variable type of cpu_logical_map to register_t

[Julien Grall <julien.grall@xxxxxxx>]

Hi Wei,

On 25/05/16 03:09, Wei Chen wrote:
> The cpu_logical_map is used to store CPU hardware ID from MPIDR_EL1 or
> from CPU node of DT. Currently, the cpu_logical_map is using the u32 as
> its variable type. It can work properly while Xen is running on ARM32,
> because the hardware ID is 32-bits. While Xen is running on ARM64, the
> hardware ID expands to 64-bits and then the cpu_logical_map will overflow.
>
> Change the the variable type of cpu_logical_map to register_t will make
NIT: s/the the/the/

> cpu_logical_map to store hardware ID correctly on ARM32 and ARM64.
s/ID/IDs/

> Signed-off-by: Wei Chen <Wei.Chen@xxxxxxxxxx>
The code looks good to me. With the typos fixed:

Acked-by: Julien Grall <julien.grall@xxxxxxx>

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel