Re: [Xen-devel] [PATCH v3 10/16] efi: create efi_enabled()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

>>> @@ -42,11 +38,12 @@ UINT64 __read_mostly efi_boot_remain_var_store_size;
>>>  UINT64 __read_mostly efi_boot_max_var_size;
>>>
>>>  struct efi __read_mostly efi = {
>>> -   .acpi   = EFI_INVALID_TABLE_ADDR,
>>> -   .acpi20 = EFI_INVALID_TABLE_ADDR,
>>> -   .mps    = EFI_INVALID_TABLE_ADDR,
>>> -   .smbios = EFI_INVALID_TABLE_ADDR,
>>> -   .smbios3 = EFI_INVALID_TABLE_ADDR,
>>> +   .flags   = 0, /* Initialized later. */
>>> +   .acpi    = EFI_INVALID_TABLE_ADDR,
>>> +   .acpi20  = EFI_INVALID_TABLE_ADDR,
>>> +   .mps     = EFI_INVALID_TABLE_ADDR,
>>> +   .smbios  = EFI_INVALID_TABLE_ADDR,
>>> +   .smbios3 = EFI_INVALID_TABLE_ADDR
>>>  };
>> This, again, is an unnecessary hunk. And in no case should you drop
> Ditto.
>
>> the trailing comma - that's there for a reason.
> What is the reason for trailing comma?

If you put in a trailing comma, subsequent patches to add a further item
become a 1 line addition, rather than a 1 subtraction and 2 addition.

It makes patches for future additions smaller and more clear.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel