[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 01/10] vt-d: fix the IOMMU flush issue

On May 25, 2016 4:30 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> The patch getting too large is easy to deal with: Split it at a reasonable
> boundary.

If I follow the below rule, I need to merge most of patches into this one. I 
can't find a reasonable boundary.
I recall your suggestion: top one first, then low level one..
I am better not to make this patch as a first one, as this is really a low 
level one.
Then, I need to change condition from 'if ( !rc )'  to ' if ( rc < 0 )' in my 
series. (but if this series would be merged together, I don't need to think 
about it.)
Does it make sense?


> It's one thing that I want to be clear: Any conversion of a void
> return type of some function to non-void should be accompanied by it at the
> same time becoming __must_check. I dislike having to repeat yet again what I
> have been saying a number of times: Without doing so, it is harder for you as
> the person writing the patch to verify all callers deal with errors, and it's
> perhaps even harder for reviewers to verify you did.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.