Re: [Xen-devel] [for-4.7 v2 2/2] xen/arm: Document the behavior of XENMAPSPACE_dev_mmio

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.05.16 at 17:56, <julien.grall@xxxxxxx> wrote:
> Currently, XENMAPSPACE_dev_mmio maps MMIO regions using one of the most
> restrictive memory attribute (Device-nGnRE).
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
irrespective of whether ...

> --- a/xen/include/public/memory.h
> +++ b/xen/include/public/memory.h
> @@ -220,7 +220,11 @@ DEFINE_XEN_GUEST_HANDLE(xen_machphys_mapping_t);
>  #define XENMAPSPACE_gmfn_range   3 /* GMFN range, XENMEM_add_to_physmap 
> only. */
>  #define XENMAPSPACE_gmfn_foreign 4 /* GMFN from another dom,
>                                      * XENMEM_add_to_physmap_batch only. */
> -#define XENMAPSPACE_dev_mmio     5 /* device mmio region */
> +#define XENMAPSPACE_dev_mmio     5 /* device mmio region
> +                                      ARM only; the region will be mapped
> +                                      in Stage-2 using the memory attribute
> +                                      "Device-nGnRE" (previously named
> +                                      "Device" on ARMv7) */

"will be" would get replaced as suggested by Stefano (I don't think
the current wording is really misleading).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel