Re: [Xen-devel] [PATCH v3] x86/mce: handle reserved domain ID in XEN_MC_msrinject

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, May 27, 2016 at 05:14:08PM +0100, Wei Liu wrote:
> On Fri, May 27, 2016 at 10:06:31AM -0600, Jan Beulich wrote:
> > >>> On 27.05.16 at 17:31, <wei.liu2@xxxxxxxxxx> wrote:
> > > On Fri, May 27, 2016 at 03:06:08PM +0100, Wei Liu wrote:
> > >> On Fri, May 27, 2016 at 08:03:42AM -0600, Jan Beulich wrote:
> > >> > >>> On 27.05.16 at 15:30, <haozhong.zhang@xxxxxxxxx> wrote:
> > >> > > Commit 26646f3 "x86/mce: translate passed-in GPA to host machine
> > >> > > address" and commit 4ddf474 "tools/xen-mceinj: Pass in GPA when
> > >> > > injecting through MSR_MCI_ADDR" forgot to consider reserved domain
> > >> > > ID and mistakenly add MC_MSRINJ_F_GPADDR flag for them, which in turn
> > >> > > causes bug reported by
> > >> > > http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg02640.html.
> > >> > > 
> > >> > > This patch removes MC_MSRINK_F_GPADDR flag and checks this when 
> > >> > > injecting
> > >> > > to reserved domain IDs except DOMID_SELF, and treats the passed-in
> > >> > > address as host machine address.
> > >> > > 
> > >> > > Signed-off-by: Haozhong Zhang <haozhong.zhang@xxxxxxxxx>
> > >> > 
> > >> > Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> > >> > 
> > >> 
> > >> Release-acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > 
> > > And queued.
> > 
> > Please wait for a maintainer ack.
> > 
> 
> $ ./scripts/get_maintainer.pl -f xen/arch/x86/cpu/mcheck/mce.c
> Christoph Egger <chegger@xxxxxxxxx>
> Liu Jinsong <jinsong.liu@xxxxxxxxxxxxxxx>
> Jan Beulich <jbeulich@xxxxxxxx>
> Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> xen-devel@xxxxxxxxxxxxx
> 

OK, so looking at MAINTAINERS file:

MACHINE CHECK (MCA) & RAS
M:      Christoph Egger <chegger@xxxxxxxxx>
M:      Liu Jinsong <jinsong.liu@xxxxxxxxxxxxxxx>
S:      Supported
F:      xen/arch/x86/cpu/mcheck/

I will revert this patch now. Sorry for all the trouble!

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel