[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.7 2/2] build: use CFLAGS instead of AFLAGS for as-insn checks

>>> On 30.05.16 at 18:27, <roger.pau@xxxxxxxxxx> wrote:
> The test code is a C file with inline assembly, not plain assembly.
> This fixes the fallout introduced by commit 7fb252bd41 ("build/xen: fix
> assembler instruction tests")

I don't follow (did you check this time that previous behavior gets
restored; you clearly can't have checked that old behavior was
retained for gcc builds with that earlier change of yours):

> --- a/Config.mk
> +++ b/Config.mk
> @@ -150,7 +150,7 @@ endif
>  # as-insn: Check whether assembler supports an instruction.
>  # Usage: cflags-y += $(call as-insn "insn",option-yes,option-no)
>  as-insn = $(if $(shell echo 'void _(void) { asm volatile ( $(2) ); }' \
> -                       | $(1) $(AFLAGS) -c -x c -o /dev/null - 
> 2>&1),$(4),$(3))
> +                       | $(1) $(CFLAGS) -c -x c -o /dev/null - 
> 2>&1),$(4),$(3))

Afaict this leaves in place the problematic -M options. Changing from
AFLAGS to CFLAGS is probably fine here (if only patch 1, which is a
prereq to the change here, was okay), but leaving out the other
change my patch did I can't see how you fix aforementioned fallout.
Please explain.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.