[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.7 1/2] build/clang: disable the usage of the integrated clang assembler

>>> On 31.05.16 at 12:31, <roger.pau@xxxxxxxxxx> wrote:
> On Tue, May 31, 2016 at 02:16:49AM -0600, Jan Beulich wrote:
>> >>> On 30.05.16 at 18:27, <roger.pau@xxxxxxxxxx> wrote:
>> > For all the build process, not only the assembly-only files.
>> > 
>> > This prevents assembling certain code with the integrated assembler, while
>> > other code would be assembled by the external assembler.
>> Without you giving a reason why this needs to be that way, I don't
>> think this is an acceptable change. I, for one, don't see why in a
>> clang build we shouldn't use as much of clang as possible (and hence
>> limit exceptions to a minimum).
> For once, the external and the integrated assembler might have a different 
> set of features, so we would have to execute some of the checks twice 
> against each of them and then choose the minimum set of features that are 
> supported by both, IMHO we don't want to get down that road.

Why not? These checks already say which flags they want to update.
And I don't think many CONFIG_AS_* uses exist in .S files, so the
amount of redundancy (to also update AFLAGS) would be small (or
even zero).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.