[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] xen: xenbus: Remove create_workqueue
Sorry about that. Will make the corrections in v2. Thanks, Bhaktipriya On Tue, May 31, 2016 at 9:48 PM, David Vrabel <david.vrabel@xxxxxxxxxx> wrote: > On 27/05/16 19:50, Bhaktipriya Shridhar wrote: >> With concurrency managed workqueues, use of dedicated workqueues can be >> replaced by using system_wq. Drop xenbus_frontend_wq by using system_wq. >> >> Since there is only a single work item, increase of concurrency level by >> switching to system_wq should not break anything. >> >> Since the work item could be pending and the code expects it to run >> once scheduled, flush_work() has been used in xenbus_dev_suspend() > > This says flush_work() but... >> >> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@xxxxxxxxx> >> --- >> drivers/xen/xenbus/xenbus_probe.c | 2 ++ >> drivers/xen/xenbus/xenbus_probe_frontend.c | 15 +-------------- >> 2 files changed, 3 insertions(+), 14 deletions(-) >> >> diff --git a/drivers/xen/xenbus/xenbus_probe.c >> b/drivers/xen/xenbus/xenbus_probe.c >> index 33a31cf..bc97019 100644 >> --- a/drivers/xen/xenbus/xenbus_probe.c >> +++ b/drivers/xen/xenbus/xenbus_probe.c >> @@ -592,6 +592,8 @@ int xenbus_dev_suspend(struct device *dev) >> >> DPRINTK("%s", xdev->nodename); >> >> + cancel_work_sync(&xdev->work); > > ...cancel_work_sync() is called here. > > David _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |