[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/cpuid: fix dom0 crash on skylake machine



>>> On 01.06.16 at 11:03, <andrew.cooper3@xxxxxxxxxx> wrote:
> While this does work, it undoes some of the work I started with my cpuid
> improvements in 4.7
> 
> Does the attached patch also resolve your issue?

While that's much better than the original, I don't think it's quite
enough. The rest of the domain policy should be taken into account
(and I think I had suggested to do so during review of your CPUID
rework series), i.e. this can't be calculated once for every domain.
And then, as said in reply to the original patch, handle_xsetbv()'s
checking should be generalized from the special casing of PKRU (or
if we don't want that, then that special case would better get
removed for consistency reasons).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.