[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 for 4.7] xen: Rename of xSplice to livepatch.



>>> On 02.06.16 at 17:18, <konrad.wilk@xxxxxxxxxx> wrote:
> On Thu, Jun 02, 2016 at 03:58:37PM +0100, Andrew Cooper wrote:
>> On 02/06/16 15:50, Jan Beulich wrote:
>> >
>> >> --- a/xen/arch/arm/xsplice.c
>> >> +++ b/xen/arch/arm/livepatch.c
>> >> @@ -4,67 +4,67 @@
>> >>  #include <xen/errno.h>
>> >>  #include <xen/init.h>
>> >>  #include <xen/lib.h>
>> >> -#include <xen/xsplice_elf.h>
>> >> -#include <xen/xsplice.h>
>> >> +#include <xen/livepatch_elf.h>
>> >> +#include <xen/livepatch.h>
>> >>  
>> >> -void arch_xsplice_patching_enter(void)
>> >> +void arch_livepatching_enter(void)
>> > Still "patching"?
>> 
>> This function came from one of my additions to the series.  It half of a
>> pair of calls around the critical region which is writing new code/data,
>> where CR0.WP needs tweaking.
>> 
>> As such, 'patching' was logically distinct from the name 'livepatch' as
>> the general namespace of these functions, and referred to the critical
>> region of actually changing live memory.
>> 
>> I am at a loss to suggest a better alternative.
> 
>  arch_quiescing_start and arch_quiescing_stop ?

arch_livepatch_quiesce() / arch_livepatch_revive()?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.