Re: [Xen-devel] [PATCH RESEND 04/14] tools: add ACPI tables relevant definitions

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 06/06/2016 11:04, Stefano Stabellini wrote:
> On Tue, 31 May 2016, Shannon Zhao wrote:
> > From: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> >
> > Add ACPI tables relevant definitions for generating ACPI tables for ARM
> > guest later. Currently RSDP, XSDT, GTDT, MADT, FADT and DSDT tables will
> > be used.
> >
> > Signed-off-by: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> > ---
> >  tools/libxc/include/acpi_defs.h | 277 ++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 277 insertions(+)
> >  create mode 100644 tools/libxc/include/acpi_defs.h
> >
> > diff --git a/tools/libxc/include/acpi_defs.h b/tools/libxc/include/acpi_defs.h
> > new file mode 100644
> > index 0000000..9389a96
> > --- /dev/null
> > +++ b/tools/libxc/include/acpi_defs.h
> > @@ -0,0 +1,277 @@
> > +#ifndef _ACPI_DEFS_H_
> > +#define _ACPI_DEFS_H_
> > +
> > +#define ACPI_BUILD_APPNAME6 "XenARM"
> > +#define ACPI_BUILD_APPNAME4 "Xen "
> This header is actually ARM specific (also see the gic stuff below). It
> is probably best to rename it to acpi_arm_defs.h.
Should not just we re-use the ACPI headers from xen/include/acpi/ ?

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel