Re: [Xen-devel] [PATCH RFC 11/20] acpi/hvmloader: Translate all addresses when assigning addresses in ACPI tables

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.04.16 at 03:25, <boris.ostrovsky@xxxxxxxxxx> wrote:
> --- a/tools/firmware/hvmloader/acpi/build.c
> +++ b/tools/firmware/hvmloader/acpi/build.c
> @@ -126,7 +126,7 @@ static struct acpi_20_madt *construct_madt(struct 
> acpi_config *config)
>      else
>          lapic = (struct acpi_20_madt_lapic *)(madt + 1);
>  
> -    config->acpi_info.madt_lapic0_addr = (uint32_t)lapic;
> +    config->acpi_info.madt_lapic0_addr = virt_to_phys(lapic);

While perhaps it doesn't matter much, considering that hvmloader
already has virt_to_phys() I think earlier patches touching lines
like the one above would better switch to using it right away,
instead of using (or even introducing) explicit casts. That'll reduce
code churn and make the history of the changes to the affected
lines more clear.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel