Re: [Xen-devel] [PATCH V6 3/3] arm/acpi: Add Server Base System Architecture UART support

[Julien Grall <julien.grall@xxxxxxx>]

Hello Shanker,

On 06/06/16 23:59, Shanker Donthineni wrote:
> The ARM Server Base System Architecture describes a generic UART
> interface. It doesn't support clock control registers, modem
> control, DMA and hardware flow control features. So, extend the
> driver probe() to handle SBSA interface and skip the accessing
> PL011 registers that are not described in SBSA document
> (ARM-DEN-0029 Version 3.0, 6 APPENDIX B: GENERIC UART).
I would mention that all the access should be 32-bit. Maybe on top of 
pl011_{write,read} too.
Other than that:

Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel