Re: [Xen-devel] [PATCH 5/5] flask/policy: comment out unused xenstore example

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Mon, May 23, 2016 at 11:05:33AM -0400, Daniel De Graaf wrote:
> Signed-off-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>

Would it be good to include in the description something like:

"You should be using the xenstore stubdomain".?

Thanks.
> ---
>  tools/flask/policy/policy/access_vectors   | 32 
> +++++++++++++++---------------
>  tools/flask/policy/policy/security_classes |  2 +-
>  2 files changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/tools/flask/policy/policy/access_vectors 
> b/tools/flask/policy/policy/access_vectors
> index 4fd61f1..8cca192 100644
> --- a/tools/flask/policy/policy/access_vectors
> +++ b/tools/flask/policy/policy/access_vectors
> @@ -6,19 +6,19 @@
>  # Note: this is an example; the xenstore daemon provided with Xen does
>  # not yet include XSM support, and the exact permissions may be defined
>  # differently if such support is added.
> -class xenstore {
> -     # read from keys owned by the target domain (if permissions allow)
> -     read
> -     # write to keys owned by the target domain (if permissions allow)
> -     write
> -     # change permissions of a key owned by the target domain
> -     chmod
> -     # change the owner of a key which was owned by the target domain
> -     chown_from
> -     # change the owner of a key to the target domain
> -     chown_to
> -     # access a key owned by the target domain without permission
> -     override
> -     # introduce a domain
> -     introduce
> -}
> +#class xenstore {
> +#    # read from keys owned by the target domain (if permissions allow)
> +#    read
> +#    # write to keys owned by the target domain (if permissions allow)
> +#    write
> +#    # change permissions of a key owned by the target domain
> +#    chmod
> +#    # change the owner of a key which was owned by the target domain
> +#    chown_from
> +#    # change the owner of a key to the target domain
> +#    chown_to
> +#    # access a key owned by the target domain without permission
> +#    override
> +#    # introduce a domain
> +#    introduce
> +#}
> diff --git a/tools/flask/policy/policy/security_classes 
> b/tools/flask/policy/policy/security_classes
> index 56595e8..069faea 100644
> --- a/tools/flask/policy/policy/security_classes
> +++ b/tools/flask/policy/policy/security_classes
> @@ -5,4 +5,4 @@
>  # security policy.
>  #
>  # Access vectors for these classes must be defined in the access_vectors 
> file.
> -class xenstore
> +#class xenstore
> -- 
> 2.5.5
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel