Re: [Xen-devel] [PATCH v7 07/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU suspending (top level ones)

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.06.16 at 10:59, <quan.xu@xxxxxxxxx> wrote:
> @@ -169,6 +203,7 @@ static int enter_state(u32 state)

Right above here we have

    if ( (error = device_power_down()) )

which is now wrong as long as SAVED_ALL is not zero.

>      {
>          printk(XENLOG_ERR "Some devices failed to power down.");
>          system_state = SYS_STATE_resume;
> +        device_power_up(error);
>          goto done;

For the goto you need to adjust "error", or else you return
something meaningless (a sort of random positive number) to your
caller.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel