Re: [Xen-devel] [PATCH v5 1/6] build: convert debug to Kconfig

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 6/8/16 12:53 PM, Julien Grall wrote:
> Hi Doug,
> 
> On 24/05/16 14:56, Doug Goldstein wrote:
>> diff --git a/xen/Rules.mk b/xen/Rules.mk
>> index 961d533..da2f490 100644
>> --- a/xen/Rules.mk
>> +++ b/xen/Rules.mk
>> @@ -20,13 +20,14 @@ include $(XEN_ROOT)/Config.mk
>>   ifeq ($(debug),y)
>>   verbose       := y
>>   frame_pointer := y
>> -else
>> -CFLAGS += -DNDEBUG
>>   endif
>>   ifeq ($(perfc_arrays),y)
>>   perfc := y
>>   endif
>>
>> +ifeq ($(origin debug),command line)
>> +$(warning "You must use 'make menuconfig' to enable/disable debug now.")
> 
> While building Xen with "debug=.." on the command Line, I got the
> warning because I have to use Kconfig now. This warning is lost among
> compilation logs.
> 
> As this is a warning, I would expect debug=... to work as previously.
> However debug= is just ignored. So I think we should replace the warning
> by an error to avoiding people spending time to understanding why debug
> has not been enabled.
> 
> Any opinions?
> 
> Regards,
> 

Julien,

Yes it needs to become an error. Right now its a warning because its
actually set at the top level. Jan suggested dropping it from the top
level and converting this to an error. But before that we need to give
the tools directory an --{enable,disable}-debug. I've got that written
but I'm at the OpenXT Summit and my dev box is off at home.

I apologize that you got bit by this.

-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel