[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] x86/time: use correct (local) time stamp in constant-TSC calibration fast path
On Thu, Jun 09, 2016 at 06:01:18AM -0600, Jan Beulich wrote: > This looks like a copy and paste mistake in commit 1b6a99892d ("x86: > Simpler time handling when TSC is constant across all power saving > states"), responsible for occasional many-microsecond cross-CPU skew of > what NOW() returns. > > Also improve the correlation between local TSC and stime stamps > obtained at the end of the two calibration handlers: Compute the stime > one from the TSC one, instead of doing another rdtsc() for that > compuation. > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> > --- > As to 4.7 inclusion: This of course looks like a pretty blatant mistake > that has been there for many years (and hence many releases). There's > certainly non-zero risk that I'm overlooking something here (despite > Joao apparently having come to the same conclusion), so I can't really > make up my mind on whether to request this patch to be put there right > away, or rather having linger in -unstable for a while. > Leave it in unstable for a while please. I don't want to delay the release any further. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |