Re: [Xen-devel] [PATCH 11/11] oxenstored: honour XEN_{LOG, RUN}_DIR in oxenstored.conf

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[PATCH 11/11] oxenstored: honour XEN_{LOG,RUN}_DIR in 
oxenstored.conf"):
> Generate oxenstored.conf with configure. This involves modifying
> tools/configure.ac and rerun autogen.sh.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: David Scott <dave@xxxxxxxxxx>

You should mention that autogen.sh should be rerun.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

> There are two hard-coded paths in logging.ml, but I'm not sure if
> generate an ocaml _Path module is the right thing to do.

I would be interested to hear Dave's opinion.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel