Re: [Xen-devel] [PATCH 2/2] oxenstored: honour XEN_LOG_DIR defined by configure

[David Scott <dave@xxxxxxxxxx>]

Hi,

Rather than

  (String.concat “” [a; b])

it’s simpler to write

  (a ^ b)

With that small change,

Acked-by: David Scott <dave@xxxxxxxxxx>

Cheers,
Dave

> On 10 Jun 2016, at 19:44, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> 
> CC Dave's correct email address.
> 
> On Fri, Jun 10, 2016 at 03:25:46PM +0100, Wei Liu wrote:
>> We generate a corresponding constant (in lower case) in paths.ml. Use
>> that in source code to get rid of hard-coded path.
>> 
>> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>> ---
>> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>> Cc: David Scot <dave.scot@xxxxxxxxxx>
>> ---
>> tools/ocaml/xenstored/logging.ml | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/tools/ocaml/xenstored/logging.ml 
>> b/tools/ocaml/xenstored/logging.ml
>> index 4c90032..d05b2d4 100644
>> --- a/tools/ocaml/xenstored/logging.ml
>> +++ b/tools/ocaml/xenstored/logging.ml
>> @@ -154,7 +154,7 @@ let make_syslog_logger facility =
>>              Syslog.log facility level s in
>>      { stop = nothing; restart = nothing; rotate = nothing; write=write }
>> 
>> -let xenstored_log_destination = ref (File "/var/log/xenstored.log")
>> +let xenstored_log_destination = ref (File (String.concat "" 
>> [Paths.xen_log_dir; "/xenstored.log"]))
>> let xenstored_log_level = ref Warn
>> let xenstored_log_nb_files = ref 10
>> let xenstored_log_nb_lines = ref 13215
>> @@ -262,7 +262,7 @@ let sanitize_data data =
>>      String.escaped data
>> 
>> let activate_access_log = ref true
>> -let access_log_destination = ref (File "/var/log/xenstored-access.log")
>> +let access_log_destination = ref (File (String.concat "" 
>> [Paths.xen_log_dir; "/xenstored-access.log"]))
>> let access_log_nb_files = ref 20
>> let access_log_nb_lines = ref 13215
>> let access_log_nb_chars = ref 180
>> -- 
>> 2.1.4
>> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel