Re: [Xen-devel] [PATCH 2/2] nested vmx: Validate host VMX MSRs before accessing them

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Euan Harris [mailto:euan.harris@xxxxxxxxxx]
> Sent: Thursday, June 09, 2016 9:21 PM
> 
> On Thu, Jun 09, 2016 at 06:47:55AM -0600, Jan Beulich wrote:
> > >      /*
> > > -     * Those MSRs are available only when bit 55 of
> > > -     * MSR_IA32_VMX_BASIC is set.
> > > +     * These MSRs are only available when flags in other MSRs are set.
> > > +     * These prerequisites are listed in the Intel 64 and IA-32
> > > +     * Architectures Software Developer’s Manual, Vol 3, Appendix A.
> > >       */
> > > -    switch ( msr )
> > > -    {
> > > +    switch ( msr ) { case MSR_IA32_VMX_PROCBASED_CTLS2:
> >
> > I hope you didn't really mean to produce a garbled line like this?
> > With proper formatting restored
> > Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Oops, definitely not.   I think this happened when I was re-wrapping
> the comment above - !}fmt went further than I intended.
> 

Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>, with above fixed.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel