[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0



Wei Liu writes ("Re: [Xen-devel] [PATCH] libxl: correct xl cpupool-numa-split 
with vcpu limited dom0"):
> On Tue, Jun 14, 2016 at 11:01:50AM +0200, Dario Faggioli wrote:
> > On Tue, 2016-06-14 at 06:30 +0200, Juergen Gross wrote:
> > > When trying to use xl cpupool-numa-split and dom0 is limited to less
> > > vcpus than one numa node the operation will fail.
> > > 
> > > Correct this by allowing this configuration.
> > > 
> > > Reported-by: Glenn Enright <glenn@xxxxxxxxxxxxxxx>
> > > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > >
> > Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> I think this is also a backport candidate?

Possibly.

I looked at the code for a minute or two, and perhaps I'm being dense
this morning, but I wasn't able to see (from the code and the commit
message and from the diff) precisely what misunderstanding the
original author of the code had, and how this patch fixes it.

I don't want to backport (non-security) things unless they have a very
low chance of regressions.  So perhaps someone could either explain it
to me, or assert convincingly that they are sure it's right :-).

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.