Re: [Xen-devel] [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jun 14, 2016 at 11:18:16AM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH 1/6] xl: remus/colo: only initialise ha variable when 
> necessary"):
> > The original code is bogus because the common case is no HA enabled.
> > Setting ha variable at the beginning is not very useful.
> 
> This seems like a plausible cleanup but I don't understand why you say
> the original code is `bogus'.  Is it wrong ?  If so you don't say how.
> 

What I meant is "the default state should be no HA enabled", hence if we
don't move the ha variable into a narrower scope it should have been
initialised to NULL first.  It is not a bug though.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel