Re: [Xen-devel] [PATCH 7/8] xen/mm: Introduce max_gfn and min_gfn

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 14/06/16 14:05, Jan Beulich wrote:
>>>> On 14.06.16 at 14:07, <julien.grall@xxxxxxx> wrote:
>> --- a/xen/include/xen/mm.h
>> +++ b/xen/include/xen/mm.h
>> @@ -70,6 +70,9 @@ TYPE_SAFE(unsigned long, gfn);
>>  #undef gfn_t
>>  #endif
>>  
>> +#define max_gfn(x, y) _gfn(max(gfn_x(x), gfn_x(y)))
>> +#define min_gfn(x, y) _gfn(min(gfn_x(x), gfn_x(y)))
> With my reply to an earlier patch in mind I think these would better
> be gfn_min() and gfn_max() (to be extended with gfn_add() and
> mfn_add() and maybe some others).

+1 to the alternative naming suggestion.

I would also suggest making these static inlines rather than defines.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel