Re: [Xen-devel] [PATCH 4/7] vm-event/x86: use vm_event_vcpu_enter properly

[Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>]

On 6/16/2016 7:27 PM, Tamas K Lengyel wrote:
> > diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c
> > index 1fec412..1e5445f 100644
> > --- a/xen/arch/x86/monitor.c
> > +++ b/xen/arch/x86/monitor.c
> > @@ -20,7 +20,6 @@
> >    */
> >
> >   #include <asm/monitor.h>
> > -#include <public/vm_event.h>
> >
> >   int arch_monitor_domctl_event(struct domain *d,
> >                                 struct xen_domctl_monitor_op *mop)
> > @@ -62,14 +61,6 @@ int arch_monitor_domctl_event(struct domain *d,
> >           else
> >               ad->monitor.write_ctrlreg_enabled &= ~ctrlreg_bitmask;
> >
> > -        if ( VM_EVENT_X86_CR3 == mop->u.mov_to_cr.index )
> > -        {
> > -            struct vcpu *v;
> > -            /* Latches new CR3 mask through CR0 code. */
> > -            for_each_vcpu ( d, v )
> > -                hvm_update_guest_cr(v, 0);
> > -        }
> > -
> So this block is not really getting relocated as the commit message
> suggests as much as being completely reworked at a different location?
> It would be better for it to be it's own separate patch as the changes
> are not trivial.
That's actually not reworked, it's completely removed since there's no 
need for it anymore.
That is: "latching of CR3 mask" is not done "through CR0" anymore but 
rather through the vm_event_vcpu_enter function instead and you don't 
have to do anything more here in arch_monitor_domctl_event for that to 
happen.
> >           domain_unpause(d);
> >
> >           break;
> Thanks,
> Tamas


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel