Re: [Xen-devel] [PATCH 12/15] xen/xsm: remove .xsm_initcall.init section

[Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>]

On 06/17/2016 01:21 PM, Konrad Rzeszutek Wilk wrote:
> On Fri, Jun 17, 2016 at 01:18:47PM -0400, Daniel De Graaf wrote:
> > On 06/17/2016 01:14 PM, Konrad Rzeszutek Wilk wrote:
> > > On Fri, Jun 17, 2016 at 01:04:01PM -0400, Daniel De Graaf wrote:
> > > > On 06/17/2016 11:50 AM, Konrad Rzeszutek Wilk wrote:
> > > > > On Thu, Jun 09, 2016 at 10:47:15AM -0400, Daniel De Graaf wrote:
> > > > > > Since FLASK is the only implementation of XSM hooks in Xen, using an
> > > > > > iterated initcall dispatch for setup is overly complex.  Change this to
> > > > > As such, should the Kconfig file enable the FLASK by default?
> > > > > Or make the XSM entry have the configuration for FLASK?
> > > > >
> > > > > Or perhaps make the FLASK be the visible one and select XSM?
> > > > XSM has previously been the configuration option to enable.  If XSM is
> > > > enabled (by choice), FLASK will then be enabled by default.
> > > Ah, OK. I need to check, but could you disable FLASK and still have XSM enabled?
> > Yes, but it won't do anything except slow down the hypervisor a bit.
> > It's the same behavior as enabling flask and passing "flask=disabled" on
> > the hypervisor command line.
> Right. Would it make sense to squash XSM and FLASK together in the Kconfig?
When making the Kconifg changes, I originally tried making a choice option for
the XSM provider (like for scheduler), with FLASK and dummy being the two
choices.  I discarded that because it didn't add anything useful over the
binary option.

However, thinking about it, if it doesn't make sense to disable FLASK then
hiding the option would simplify the configuration. It removes the grouping of
flask-only options, but since there's only one that isn't all that important.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel