Re: [Xen-devel] [PATCH] x86: compact supposedly unused entry point code

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 20/06/16 13:48, Jan Beulich wrote:
>>>> On 20.06.16 at 14:15, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 20/06/16 12:04, Jan Beulich wrote:
>>> No point in aligning entry points which aren't supposed to be used
>>> anyway.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Thanks, but - any thoughts on this part:
>
> TBD: Might consider simply using "andq $-15,%rsp", delivering an
> uninitialized error code (which shouldn't matter).

I was still considering that part.

These are entries we never expect to actually take.  At that point, the
small overhead of setting up the error code to 0 is probably better than
leaving it uninitialised.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel