Re: [Xen-devel] [PATCH 4/8] xen/arm: vgic: Use dynamic memory allocation for vgic_rdist_region

[Julien Grall <julien.grall@xxxxxxx>]

Hello Shanker,

On 19/06/16 00:45, Shanker Donthineni wrote:
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index 370cdeb..9492727 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -40,6 +40,12 @@ struct vtimer {
>           uint64_t cval;
>   };
>
> +struct vgic_rdist_region {
> +    paddr_t base;                  /* Base address */
> +    paddr_t size;                  /* Size */
> +    unsigned int first_cpu;        /* First CPU handled */
> +};
> +
>   struct arch_domain
>   {
>   #ifdef CONFIG_ARM_64
> @@ -103,11 +109,7 @@ struct arch_domain
>   #ifdef CONFIG_HAS_GICV3
>           /* GIC V3 addressing */
>           /* List of contiguous occupied by the redistributors */
> -        struct vgic_rdist_region {
> -            paddr_t base;                   /* Base address */
> -            paddr_t size;                   /* Size */
> -            unsigned int first_cpu;         /* First CPU handled */
> -        } rdist_regions[MAX_RDIST_COUNT];
> +        struct vgic_rdist_region *rdist_regions;
I don't think it is necessary to move the definition of 
vgic_rdist_region outside.
>           int nr_regions;                     /* Number of rdist regions */
>           uint32_t rdist_stride;              /* Re-Distributor stride */
>   #endif
> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> index a2fccc0..fbb763a 100644
> --- a/xen/include/asm-arm/vgic.h
> +++ b/xen/include/asm-arm/vgic.h
> @@ -128,6 +128,8 @@ struct vgic_ops {
>       int (*vcpu_init)(struct vcpu *v);
>       /* Domain specific initialization of vGIC */
>       int (*domain_init)(struct domain *d);
> +    /* Release resources that are allocated by domain_init */
> +    void (*domain_free)(struct domain *d);
>       /* vGIC sysreg emulation */
>       int (*emulate_sysreg)(struct cpu_user_regs *regs, union hsr hsr);
>       /* Maximum number of vCPU supported */
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel