Re: [Xen-devel] [PATCH v2] x86/HVM: use available linear->phys translations in REP MOVS/STOS handling

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.06.16 at 21:50, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 20/06/16 12:29, Jan Beulich wrote:
>> If we have the translation result available already, we should also use
>> it here. In my tests with Linux guests this eliminates all calls to
>> hvmemul_linear_to_phys() from the STOS path and most from the MOVS one.
>>
>> Also record the translation for re-use at least during response
>> processing.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> This patch is still broken.  All XenServer HVM guests (both windows and
> linux) are dying, with Qemu citing

_All_? That contradicts both my own testing and osstest's smoke
one having succeeded.

> I/O request not read: 0, ptr: 0, port: 0, data: 0, count: 0, size: 0

This doesn't look like a valid request, and I the patch at hand doesn't
alter requests generated in any way. Is it perhaps unmasking a
problem in some private XenServer patch? For now, unless your
claim would get supported by osstest's main round of testing, or
unless you or someone else can point out what's still wrong with v2,
I'm not really inclined to revert right away.

Otoh - iirc you run with qemu-trad, and I guess I didn't test that, so
let me try...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel