[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] xen: arm: Update arm64 image header



Hi Konrad,

On 22/06/16 15:29, Konrad Rzeszutek Wilk wrote:
Oh, indeed!


My patch doesn't change anything regarding the fact that if the magics are
not valid (due to quite old kernel version) the code does exit with an
error.

/me nods

While the review of v1 of this patch, Julien asked for an error message to
be added here. Fine.

But if there is the request to change the behavior regarding which kernels
are supported I'd think that this is independent on this patch and should be
done in an additional patch.

Right, and I think it is fine to skip that  - because as you say - it
already ignores older kernels.

This is not right. The current version of Xen is not ignoring older kernels.

The current check allows kernels with only MAGIC_V0 (any Linux older than
3.12) to be detected by Xen.

However, this is impacting only one version because support for Xen on ARM64
was added in Linux 3.11.

And you ARM maintainers are OK ditching that support?

The number of board supported by Linux 3.11 on ARM64 is very limited: ARM models and X-gene.

For the latter it was an early support with only the serial and timer upstreamed (see [1]).

So personally I am fine with that. Any opinions?


It probably also means updating some Wiki page and docs.

Good point. Although we don't seem to mention the first Linux version supported for ARM64 [2].

Cheers,

[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/apm-storm.dtsi?h=v3.11 [2] http://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions#Requirements

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.