Re: [Xen-devel] [PATCH v1 Altp2m cleanup 0/3] Cleaning up altp2m code

["Lai, Paul C" <paul.c.lai@xxxxxxxxx>]

Jan:

Ok... adding back xen-devel.

Thanks for the pointer to the thread.

I'm looking at the existing Xen code and the changes mentioned by George (and 
supported by Tim) are already in.  The patch suggested by George is
  http://lists.xenproject.org/archives/html/xen-devel/2015-07/txtEYYYL6ATei.txt
from George's post of  
http://lists.xenproject.org/archives/html/xen-devel/2015-07/msg01088.html

The current code has the following snippets, which match/mirror the intent of 
the above referenced patch.

xen/arch/x86/mm/mem_sharing.c:
...
+        bool_t sve;
 
         if ( atomic_read(&d->shr_pages) == 0 )
             break;
-        mfn = p2m->get_entry(p2m, gfn, &t, &a, 0, NULL);
+        mfn = p2m->get_entry(p2m, gfn, &t, &a, 0, NULL, NULL);

xen/arch/x86/mm/p2m-ept.c:
.... 
    if ( sve != -1 )
        new_entry.suppress_ve = !!sve;
    else
        new_entry.suppress_ve = is_epte_valid(&old_entry) ?
                                    old_entry.suppress_ve : 1;
...

[WRT side note: it's easier to see what your referring to if you present what 
you see.  If I search, I'm guessing at what you're referring to.  Often (at 
least for me), I end up have two different conversations.]

Regards, -Paul

-----Original Message-----
From: Jan Beulich [mailto:JBeulich@xxxxxxxx] 
Sent: Wednesday, June 22, 2016 8:54 AM
To: Lai, Paul C <paul.c.lai@xxxxxxxxx>
Cc: Sahita, Ravi <ravi.sahita@xxxxxxxxx>
Subject: RE: [PATCH v1 Altp2m cleanup 0/3] Cleaning up altp2m code

>>> On 22.06.16 at 17:26, <paul.c.lai@xxxxxxxxx> wrote:
> Dropping Xen-devel.

Not sure why, but anyway.

> Jan/Ravi: 
> 
> Please send me reminder for the " main work item was to get rid of the 
> multitude of function parameters the set_entry()".  This wasn't in the 
> instructions I (if I recall correctly) was given.

See for example
http://lists.xenproject.org/archives/html/xen-devel/2015-07/msg01331.html
and the surrounding thread, as well as replies to later versions of this same 
patch.

(As a side note, it's not clear to me why you made me search xen-devel for this 
discussion, when you could have just as easily done this yourself.)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel