[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/arm: domain_build: DT: add clocks node to the hypervisor node



On 22/06/16 16:58, Julien Grall wrote:
On 21/06/16 11:15, Dirk Behme wrote:
+            printk("Failed to remember the clock node of %s\n", path);
+            printk("Use the Linux kernel command
'clk_ignore_unused'\n");
+            return 0;

I don't think this is tolerable. We need to fix it  once and for all.

I understand that xen does not provide a realloc function. Is there
another way we can get a rid of this limit?

Note that I would wait that we agree on the device tree bindings before reworking this patch. It will avoid you to waste time if we decide to move towards a different solution.

I am wondering if we can use the member domain_list of dt_device_node to
link the device having a clock property. And then latter one, allocate
the memory + copying the data.

+        }
+        memcpy(&kinfo->clk.dtclocks[kinfo->clk.cnt], clocks, len);
+        kinfo->clk.cnt += len;
          return 0;
      }


Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.