Re: [Xen-devel] [PATCH v4 3/3] xen: make available hvm_fep to non-debug build as well

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 6/23/16 10:10 AM, Wei Liu wrote:
> Originally hvm_fep was guarded by NDEBUG, which means it was only
> available to debug builds.
> 
> However there is value to have it for non-debug builds as well. User can
> use that to run tests in setup that replicates production setup.

"Users can use it to run tests in a setup that replicates a production
setup" is what I think was meant?

> 
> Make it clear with a sync_console style warning that this option can't
> be used in production setup. Update command line documentation
> accordingly. Finally mark Xen as tainted when this feature is used.
> 
> Add a kconfig option under x86 to configure hvm_fep.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Otherwise the change looks good.

Reviewed-by: Doug Goldstein <cardoe@xxxxxxxxxx>

-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel