Re: [Xen-devel] [PATCH] xen: x86: remove duplicated MSR_IA32_FEATURE_CONTROL definition

["Huang, Kai" <kai.huang@xxxxxxxxxxxxxxx>]

On 6/22/2016 11:44 PM, Jan Beulich wrote:
> > > > On 22.06.16 at 12:17, <kaih.linux@xxxxxxxxx> wrote:
> > @@ -288,7 +289,6 @@
> >  #define MSR_IA32_PLATFORM_ID           0x00000017
> >  #define MSR_IA32_EBL_CR_POWERON                0x0000002a
> >  #define MSR_IA32_EBC_FREQUENCY_ID      0x0000002c
> > -#define MSR_IA32_FEATURE_CONTROL       0x0000003a
> >  #define MSR_IA32_TSC_ADJUST            0x0000003b
> The latest when removing the definition here you should have noticed
> that this variant follows the conventional naming, so if you want to
> consolidate things, it should be the other way around imo. While not
> the main reason, it'll also make sure mwait-idle.c won't needlessly
> diverge from its Linux original.
You are right. I'll sent out another patch removing the old one.

Thanks,
-Kai
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel