Re: [Xen-devel] [PATCH v12 6/6] vt-d: fix vt-d Device-TLB flush timeout issue

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.06.16 at 11:18, <quan.xu@xxxxxxxxx> wrote:
> On June 24, 2016 7:55 PM, Tian, Kevin <kevin.tian@xxxxxxxxx> wrote:
>> > From: Xu, Quan
>> > Sent: Friday, June 24, 2016 1:52 PM
>> > diff --git a/xen/drivers/passthrough/vtd/extern.h
>> > b/xen/drivers/passthrough/vtd/extern.h
>> > index 45357f2..efaff28 100644
>> > --- a/xen/drivers/passthrough/vtd/extern.h
>> > +++ b/xen/drivers/passthrough/vtd/extern.h
>> > @@ -25,6 +25,7 @@
>> >
>> >  #define VTDPREFIX "[VT-D]"
>> >
>> > +struct pci_ats_dev;
>> >  extern bool_t rwbf_quirk;
>> >
>> >  void print_iommu_regs(struct acpi_drhd_unit *drhd); @@ -60,8 +61,8 @@
>> > int dev_invalidate_iotlb(struct iommu *iommu, u16 did,
>> >                           u64 addr, unsigned int size_order, u64
>> > type);
>> >
>> >  int __must_check qinval_device_iotlb_sync(struct iommu *iommu,
>> > -                                          u32 max_invs_pend,
>> > -                                          u16 sid, u16 size, u64 addr);
>> > +                                          struct pci_ats_dev *ats_dev,
>> > +                                          u16 did, u16 size, u64
>> > + addr);
>> >
>> >  unsigned int get_cache_line_size(void);  void cacheline_flush(char
>> > *); diff --git a/xen/drivers/passthrough/vtd/qinval.c
>> > b/xen/drivers/passthrough/vtd/qinval.c
>> > index 4492b29..e4e2771 100644
>> > --- a/xen/drivers/passthrough/vtd/qinval.c
>> > +++ b/xen/drivers/passthrough/vtd/qinval.c
>> > @@ -27,11 +27,11 @@
>> >  #include "dmar.h"
>> >  #include "vtd.h"
>> >  #include "extern.h"
>> > +#include "../ats.h"
>> 
>> Earlier you said:
>> >    1. a forward declaration struct pci_ats_dev*, instead of
>> >       including ats.h.
>>
> 
> This context is 'in extern.h', but..
> 
>> But above you still have ats.h included.
>> 
> 
> .. I really need to include 'ats.h' here, as the 'struct pci_ats_dev*' is 
> used in this file.

Used as in "a variable of this type, or a pointer to this type
de-referenced", or only as in "a variable/parameter of pointer
to this type declared"? In the latter case you don't need the
include.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel