Re: [Xen-devel] [PATCH v2 15/17] libxl/arm: Add ACPI module

[Julien Grall <julien.grall@xxxxxxx>]

Hi Shannon,

On 25/06/16 04:22, Shannon Zhao wrote:
> On 2016/6/24 2:35, Julien Grall wrote:
> > Hi Shannon,
> >
> > On 23/06/2016 04:17, Shannon Zhao wrote:
> > > From: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> > >
> > > Add the ARM Multiboot module for ACPI, so UEFI or DomU can get the base
> > > address of ACPI tables from it.
> > >
> > > Signed-off-by: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> > > ---
> > >   docs/misc/arm/device-tree/acpi.txt | 23 +++++++++++++++++++++++
> > >   tools/libxl/libxl_arm.c            | 24 ++++++++++++++++++++++++
> > >   2 files changed, 47 insertions(+)
> > >   create mode 100644 docs/misc/arm/device-tree/acpi.txt
> > >
> > > diff --git a/docs/misc/arm/device-tree/acpi.txt
> > > b/docs/misc/arm/device-tree/acpi.txt
> > > new file mode 100644
> > > index 0000000..c39c4d0
> > > --- /dev/null
> > > +++ b/docs/misc/arm/device-tree/acpi.txt
> > > @@ -0,0 +1,23 @@
> > > +DomU ACPI module
> > > +================================
> > > +
> > > +Xen toolstack passes the domU ACPI tables via a reference in the
> > > /chosen node of
> > > +the device tree.
> > > +
> > > +Each node contains the following properties:
> > > +
> > > +- compatible
> > > +
> > > +    "xen,guest-acpi", "multiboot,module"
> > > +
> > > +- reg
> > > +
> > > +    Specifies the physical address and the length of the module.
> > We need to clarify how the firmware can find the RSDP. I.e will it
> > always be at the beginning of the region?
> >
> > Also, do we really need the size of the region? Would not be simpler to
> > give the base address of RSDP?
> Maybe it needs for some other UEFI implementations which will directly
> pass the ACPI tables information with a UEFI memory map to guest like
> you said. So maybe it needs the size to construct the UEFI memory map.
Good point.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel