Re: [Xen-devel] [PATCH V2 05/10] xen/arm: vgic: Use dynamic memory allocation for vgic_rdist_region

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

>> to a compile time macro MAX_RDIST_COUNT which is 4. On some systems,
>
> s/a compile time macro/a define/
> s/On some/Some/
>
>> especially latest server chips might have more than 4 redistributors.
>
> I would add a comma after 'chips'.

In English, rules for dual commas forming a subclause like this are that
the sentence still makes grammatical sense if the subclause is omitted.

Therefore

"On some systems, especially latest server chips, might have more than 4
redistributors."

is expected be equivalent to

"On some systems might have more than 4 redistributors."


The latter however doesn't make sense.

May I recommend instead:

"Some systems, especially latest server chips, may have more than 4
redistributors."

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel