[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v12 4/6] IOMMU/x86: using a struct pci_dev* instead of SBDF



>>> On 27.06.16 at 13:11, <quan.xu@xxxxxxxxx> wrote:
> On June 27, 2016 4:17 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>> >>> On 24.06.16 at 07:51, <quan.xu@xxxxxxxxx> wrote:
>> > @@ -98,7 +104,13 @@ void disable_ats_device(int seg, int bus, int
>> > devfn)
>> 
>> For symmetry reasons this function would also get converted to taking const
>> struct pci_dev *.
>> 
> 
> What about ' struct pci_dev *', without const?

Sure - since the other one apparently can't have the const added,
this one doesn't need to either (but please nevertheless do add it
it that's actually possible without having to cast away constness
somewhere.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.